linux-kernel - Re: [PATCH] ARM: dts: stm32: fix stm32mp157c-odyssey card detect pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YK/6IHCBdIU3UBqs@nx64de-df6d00>
Date:   Thu, 27 May 2021 21:59:28 +0200
From:   Grzegorz Szymaszek <gszymaszek@...rt.pl>
To:     unlisted-recipients:; (no To-header on input)
Cc:     Grzegorz Szymaszek <gszymaszek@...rt.pl>,
        Ahmad Fatoum <a.fatoum@...gutronix.de>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Marcin Słoniewski <marcin.sloniewski@...il.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com
Subject: Re: [PATCH] ARM: dts: stm32: fix stm32mp157c-odyssey card detect pin

On Sat, Apr 10, 2021 at 09:35:21PM +0200, Grzegorz Szymaszek wrote:
> The microSD card detect pin is physically connected to the MPU pin PI3.
> The Device Tree configuration of the card detect pin was wrong—it was
> set to pin PB7 instead. If such configuration was used, the kernel would
> hang on “Waiting for root device” when booting from a microSD card.
> 
> Signed-off-by: Grzegorz Szymaszek <gszymaszek@...rt.pl>
> ---
>  arch/arm/boot/dts/stm32mp157c-odyssey.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/stm32mp157c-odyssey.dts b/arch/arm/boot/dts/stm32mp157c-odyssey.dts
> index a7ffec8f1516..be1dd5e9e744 100644
> --- a/arch/arm/boot/dts/stm32mp157c-odyssey.dts
> +++ b/arch/arm/boot/dts/stm32mp157c-odyssey.dts
> @@ -64,7 +64,7 @@ &sdmmc1 {
>  	pinctrl-0 = <&sdmmc1_b4_pins_a>;
>  	pinctrl-1 = <&sdmmc1_b4_od_pins_a>;
>  	pinctrl-2 = <&sdmmc1_b4_sleep_pins_a>;
> -	cd-gpios = <&gpiob 7 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
> +	cd-gpios = <&gpioi 3 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
>  	disable-wp;
>  	st,neg-edge;
>  	bus-width = <4>;
> -- 
> 2.30.2
> 

A gentle ping. FWIW, there was another patch that would deal with the
same issue:
<https://st-md-mailman.stormreply.com/pipermail/linux-stm32/2021-April/011132.html>,
but it took the more radical approach of of replacing cd-gpios with
broken-cd.

-- 
Grzegorz