linux-kernel - Re: [PATCH v10 07/33] mm: Add folio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210527155331.3d96fca84dd25705f5c9897f@linux-foundation.org>
Date:   Thu, 27 May 2021 15:53:31 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Matthew Wilcox <willy@...radead.org>,
        Vlastimil Babka <vbabka@...e.cz>,
        linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, Zi Yan <ziy@...dia.com>,
        Christoph Hellwig <hch@....de>,
        Jeff Layton <jlayton@...nel.org>
Subject: Re: [PATCH v10 07/33] mm: Add folio_get

On Thu, 27 May 2021 09:10:31 +0100 Christoph Hellwig <hch@...radead.org> wrote:

> On Fri, May 14, 2021 at 03:24:26PM +0100, Matthew Wilcox wrote:
> > On Fri, May 14, 2021 at 01:56:46PM +0200, Vlastimil Babka wrote:
> > > Nitpick: function names in subject should IMHO also end with (). But not a
> > > reason for resend all patches that don't...
> > 
> > Hm, I thought it was preferred to not do that.  I can fix it
> > easily enough when I go through and add the R-b.
> 
> I hate the pointless ().  Some maintainers insist on it.   No matter
> what you do you'll make some folks happy and others not.

I prefer it.  It succinctly says "this identifier is a function" which
is useful info.

I get many changelogs saying "the foo function" or "the function foo". 
"foo()" is better.