linux-kernel - Re: [PATCH 1/3] perf core: Make local function perf_pmu_snapshot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 27 May 2021 11:50:41 +0800
From:   Haocheng Xie <xiehaocheng.cn@...il.com>
To:     peterz@...radead.org
Cc:     acme@...nel.org, alexander.shishkin@...ux.intel.com,
        jolsa@...hat.com, linux-kernel@...r.kernel.org,
        linux-perf-users@...r.kernel.org, mark.rutland@....com,
        mingo@...nel.org, mingo@...hat.com, namhyung@...nel.org,
        xiehaocheng.cn@...il.com
Subject: Re: [PATCH 1/3] perf core:  Make local function perf_pmu_snapshot_aux() static

* Peter Zijlstra <peterz@...radead.org> wrote:
>
> On Wed, May 26, 2021 at 07:52:18PM +0800, Haocheng Xie wrote:
> > Fixes the following W=1 kernel build warning:
> >   kernel/events/core.c:6670:6: warning: no previous prototype for 'perf_pmu_snapshot_aux' [-Wmissing-prototypes]
> >
> > Signed-off-by: Haocheng Xie <xiehaocheng.cn@...il.com>
> > ---
> >  kernel/events/core.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/events/core.c b/kernel/events/core.c
> > index 6fee4a7..0d98d6a 100644
> > --- a/kernel/events/core.c
> > +++ b/kernel/events/core.c
> > @@ -6667,7 +6667,7 @@ static unsigned long perf_prepare_sample_aux(struct perf_event *event,
> >       return data->aux_size;
> >  }
> >
> > -long perf_pmu_snapshot_aux(struct perf_buffer *rb,
> > +static long perf_pmu_snapshot_aux(struct perf_buffer *rb,
> >                          struct perf_event *event,
> >                          struct perf_output_handle *handle,
> >                          unsigned long size)
>
> Your $subject is broken (superfluous whitespace) and you've wrecked
> alignment of the arguments in the core.

Hi, Peter:
  Sorry for bothering you for these simple mistakes.
  I will optimize my patch series and send a "v2" version after that.

Thanks,

Haocheng Xie