linux-kernel - Re: [PATCH RESEND v2] PCI/IOV: Clarify error message for unbound devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210527231253.GA1442161@bjorn-Precision-5520>
Date:   Thu, 27 May 2021 18:12:53 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Moritz Fischer <mdf@...nel.org>
Cc:     bhelgaas@...gle.com, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, moritzf@...gle.com,
        Brian Foley <bpfoley@...gle.com>,
        Krzysztof Wilczyński <kw@...ux.com>
Subject: Re: [PATCH RESEND v2] PCI/IOV: Clarify error message for unbound
 devices

On Sat, Mar 27, 2021 at 10:51:40AM -0700, Moritz Fischer wrote:
> Be more verbose to disambiguate the error case when trying to configure
> SRIOV with no driver bound vs. a driver that does not implement the
> SRIOV callback.
> 
> Reported-by: Brian Foley <bpfoley@...gle.com>
> Reviewed-by: Krzysztof Wilczyński <kw@...ux.com>
> Signed-off-by: Moritz Fischer <mdf@...nel.org>

Applied to pci/virtualization for v5.14, thanks!

> ---
> Changes from v1:
> - Added Krzysztof's Reviewed-by
> ---
>  drivers/pci/iov.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c
> index 4afd4ee4f7f0..f9ecc691daf5 100644
> --- a/drivers/pci/iov.c
> +++ b/drivers/pci/iov.c
> @@ -304,8 +304,15 @@ static ssize_t sriov_numvfs_store(struct device *dev,
>  	if (num_vfs == pdev->sriov->num_VFs)
>  		goto exit;
>  
> +	/* is PF driver loaded */
> +	if (!pdev->driver) {
> +		pci_info(pdev, "No driver bound to device. Cannot configure SRIOV\n");
> +		ret = -ENOENT;
> +		goto exit;
> +	}
> +
>  	/* is PF driver loaded w/callback */
> -	if (!pdev->driver || !pdev->driver->sriov_configure) {
> +	if (!pdev->driver->sriov_configure) {
>  		pci_info(pdev, "Driver does not support SRIOV configuration via sysfs\n");
>  		ret = -ENOENT;
>  		goto exit;
> -- 
> 2.30.2
>