linux-kernel - Re: Suggestion on how to fix "memory leak in snd_ctl_led

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD-N9QWqPLd6Y0EUxAsjfE5t0HxZkJWAk3myudUwAtC_EU-Mew@mail.gmail.com>
Date:   Thu, 27 May 2021 12:47:45 +0800
From:   慕冬亮 <mudongliangabcd@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     rafael@...nel.org, linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: Suggestion on how to fix "memory leak in snd_ctl_led_register"

On Thu, May 27, 2021 at 12:20 PM 慕冬亮 <mudongliangabcd@...il.com> wrote:
>
> On Thu, May 27, 2021 at 12:17 PM Greg KH <gregkh@...uxfoundation.org> wrote:
> >
> > On Thu, May 27, 2021 at 10:49:22AM +0800, 慕冬亮 wrote:
> > > Hi kernel developers,
> > >
> > > The root cause of "memory leak in snd_ctl_led_register" [1] is
> > > unbalanced refcount operations in the device_add function [2]. This
> > > refcount issue causes struct device_private allocated in
> > > device_private_init unable to be deallocated, leading to memory leak.
> > > The details are as follows:
> >
> > <snip>
> >
> > Great, can you just send a patch to us to resolve the issue?  That's the
> > easiest way to resolve all of this.

Let me think more about the fix. I will send a patch if I can test it
successfully in my local workspace.

>
> As I said in the last, I think up some fixes, but they are not working
> in my local testing. So I have no idea how to fix this bug. Then I ask
> for help.
>
> >
> > thanks,
> >
> > greg k-h