linux-kernel - Re: [RFC PATCH] x86/apic: Fix BUG due to multiple allocation of legacy vectors.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 May 2021 15:13:26 +1000
From:   imran.f.khan@...cle.com
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     x86@...nel.org, hpa@...or.com, linux-kernel@...r.kernel.org,
        mingo@...hat.com, bp@...en8.de
Subject: Re: [RFC PATCH] x86/apic: Fix BUG due to multiple allocation of
 legacy vectors.

Hi Thomas,

On 26/5/21 12:51 am, Thomas Gleixner wrote:
> Imran,
> 
> On Mon, May 24 2021 at 13:29, imran f. khan wrote:
[...]
> 
>> Even my current setup that was crashing with in-house 5.4 and 5.8
>> kernels, boots fine if I boot it with noapic option removed from kernel
>> boot parameters.
> 
> May I ask the obvious question why the changelog of your patch did not
> mention that this happens only with 'noapic' on the kernel command line?
> 
I was not aware of it earlier. After your first feedback I debugged the 
code further with ML tag and found out about the noapic dependency.
[...]
> 
> Correct. So you almost decoded the underlying problem.
> 
[...]
> So the right thing to do is to ensure that the legacy interrupts are
> marked as system vectors in case that the IO/APIC is disabled via
> config, kernel command line or lack of enumeration. See below.
> 
Thanks for clarifying it. I have tested your change in my local setup as 
well and it works well.

Thanks,
Imran