linux-kernel - Re: [PATCH] Input: elants_i2c - Fix NULL dereference at probing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hmtsg8zmn.wl-tiwai@suse.de>
Date:   Thu, 27 May 2021 08:22:24 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Dmitry Osipenko <digetx@...il.com>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH] Input: elants_i2c - Fix NULL dereference at probing

On Wed, 26 May 2021 22:44:59 +0200,
Dmitry Osipenko wrote:
> 
> Hello all,
> 
> 26.05.2021 23:19, Dmitry Torokhov пишет:
> > Hi Takashi,
> > 
> > On Wed, May 26, 2021 at 09:43:01PM +0200, Takashi Iwai wrote:
> >> The recent change in elants_i2c driver to support more chips
> >> introduced a regression leading to Oops at probing.  The driver reads
> >> id->driver_data, but the id may be NULL depending on the device type
> >> the driver gets bound.
> >>
> >> Add a NULL check and falls back to the default EKTH3500.
> > 
> > Thank you for the patch. I think my preference would be to switch to
> > device_get_match_data() and annotate the rest of the match tables with
> > proper controller types.
> 
> Doesn't a NULL mean that elants_i2c_id[] table fails to match the ACPI
> device name? What is the name then?

I don't own the device, so we need to ask on (open)SUSE Bugzilla.

> This could be two patches:
>   1 - trivial fix that can be backported easily
>   2 - switch to device_get_match_data()

I guess 2 is easy enough to backport to 5.12.x.  Let's see.


thanks,

Takashi