linux-kernel - Re: [PATCH] softirq/s390: Use the generic local_softirq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 May 2021 02:06:23 +0200
From:   Vasily Gorbik <gor@...ux.ibm.com>
To:     Yejune Deng <yejune.deng@...il.com>
Cc:     hca@...ux.ibm.com, borntraeger@...ibm.com, tglx@...utronix.de,
        keescook@...omium.org, linux-s390@...r.kernel.org,
        linux-kernel@...r.kernel.org, Yejune Deng <yejunedeng@...il.com>
Subject: Re: [PATCH] softirq/s390: Use the generic local_softirq_pending()

On Mon, May 24, 2021 at 08:39:17PM +0800, Yejune Deng wrote:
> Defined local_softirq_pending_ref macro and get rid of {local, set, or}
> _softirq_pending macros. use {local, set, or}_softirq_pending
> in <linux/interrupt.h> that rely on per-CPU mutators.
> 
> Signed-off-by: Yejune Deng <yejunedeng@...il.com>
> ---
>  arch/s390/include/asm/hardirq.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/arch/s390/include/asm/hardirq.h b/arch/s390/include/asm/hardirq.h
> index 58668ff..ea643d6 100644
> --- a/arch/s390/include/asm/hardirq.h
> +++ b/arch/s390/include/asm/hardirq.h
> @@ -13,9 +13,7 @@
>  
>  #include <asm/lowcore.h>
>  
> -#define local_softirq_pending() (S390_lowcore.softirq_pending)
> -#define set_softirq_pending(x) (S390_lowcore.softirq_pending = (x))
> -#define or_softirq_pending(x)  (S390_lowcore.softirq_pending |= (x))
> +#define local_softirq_pending_ref  S390_lowcore.softirq_pending

S390_lowcore is not a per-CPU variable, so it cannot be accessed with
__this_cpu_read/write...

"lowcore" is a kind of hardware "per-CPU" area on s390. Each cpu accessing
first 2 pages at the real address 0 is actually touching pages at the
"absolute" address specified by prefix register of this cpu.