linux-kernel - Re: [PATCH mfd v1] mfd: Add Renesas Synchronization Management Unit (SMU) support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210527084353.GJ543307@dell>
Date:   Thu, 27 May 2021 09:43:53 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Min Li <min.li.xe@...esas.com>
Cc:     "sameo@...ux.intel.com" <sameo@...ux.intel.com>,
        "grant.likely@...aro.org" <grant.likely@...aro.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH mfd v1] mfd: Add Renesas Synchronization Management Unit
 (SMU) support

On Wed, 26 May 2021, Min Li wrote:

> > 
> > > +	ret = rsmu_dev_init(rsmu);
> > > +	mutex_unlock(&rsmu->lock);
> > > +
> > > +	if (ret == 0)
> > > +		dev_info(rsmu->dev, "Probe %s successful\n",
> > > +			 rsmu_name(rsmu->type));
> > 
> > No thank you.  Please remove this.
> > 
> Hi Lee
> 
> What is the rule for adding informational log in the driver probe function?

The rule generally is 'don't'.

Especially if it doesn't provide any actual information.

Strings are expensive with regards to binary size.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog