linux-kernel - Re: [PATCH -next] regulator: bd71815: fix platform_no_drv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <192b23ebcd712ea5b59720e6d0fc32f97317fe32.camel@fi.rohmeurope.com>
Date:   Thu, 27 May 2021 10:10:54 +0000
From:   "Vaittinen, Matti" <Matti.Vaittinen@...rohmeurope.com>
To:     "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "zou_wei@...wei.com" <zou_wei@...wei.com>
CC:     linux-power <linux-power@...rohmeurope.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] regulator: bd71815: fix platform_no_drv_owner.cocci
 warnings


On Thu, 2021-05-27 at 17:54 +0800, Zou Wei wrote:
> ./drivers/regulator/bd71815-regulator.c:644:3-8: No need to set
> .owner here. The core will do it.
> 
>  Remove .owner field if calls are used which set it automatically
> 
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zou Wei <zou_wei@...wei.com>

Thanks!
Acked-by: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>

> ---
>  drivers/regulator/bd71815-regulator.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/regulator/bd71815-regulator.c
> b/drivers/regulator/bd71815-regulator.c
> index a079efa..4dd21ac 100644
> --- a/drivers/regulator/bd71815-regulator.c
> +++ b/drivers/regulator/bd71815-regulator.c
> @@ -641,7 +641,6 @@ MODULE_DEVICE_TABLE(platform, bd7181x_pmic_id);
>  static struct platform_driver bd7181x_regulator = {
>  	.driver = {
>  		.name = "bd7181x-pmic",
> -		.owner = THIS_MODULE,
>  	},
>  	.probe = bd7181x_probe,
>  	.id_table = bd7181x_pmic_id,