linux-kernel - Re: [PATCH rdma-next v1 1/2] RDMA: Enable Relaxed Ordering by default for kernel ULPs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YK90MOp0ZKeUMf5w@infradead.org>
Date:   Thu, 27 May 2021 11:28:00 +0100
From:   Christoph Hellwig <hch@...radead.org>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...dia.com>,
        Avihai Horon <avihaih@...dia.com>,
        linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org
Subject: Re: [PATCH rdma-next v1 1/2] RDMA: Enable Relaxed Ordering by
 default for kernel ULPs

The way this is implemented looks confusing and error prone to me.

I'd like to suggest the following:

 1) add a prep patch that entirely untangles IB_ACCESS_* from
    IB_UVERBS_ACCESS.  Maybe even add a __bitwise type for IB_ACCESS_*
    to allow sparse based type checking.  Preferably ib_check_mr_access
    could be changed into a function that does this translation as it
    needs to be called anyway.
 2) then just invert IB_ACCESS_RELAXED_ORDERING while keeping
    IB_UVERBS_ACCESS_REMOTE_ATOMIC as-is, and enable
    IB_ACCESS_STRICT_ORDERING if IB_UVERBS_ACCESS_REMOTE_ATOMIC is not
    set in ib_check_mr_access.