linux-kernel - Re: [PATCH 0/9] Drop ROHM BD70528 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <de5a85b755799db771616147da36de7d5af17a6f.camel@fi.rohmeurope.com>
Date:   Thu, 27 May 2021 10:35:44 +0000
From:   "Vaittinen, Matti" <Matti.Vaittinen@...rohmeurope.com>
To:     "Vaittinen, Matti" <Matti.Vaittinen@...rohmeurope.com>
CC:     "wim@...ux-watchdog.org" <wim@...ux-watchdog.org>,
        "sre@...nel.org" <sre@...nel.org>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        linux-power <linux-power@...rohmeurope.com>,
        "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mturquette@...libre.com" <mturquette@...libre.com>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "a.zummo@...ertech.it" <a.zummo@...ertech.it>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "bgolaszewski@...libre.com" <bgolaszewski@...libre.com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        "lee.jones@...aro.org" <lee.jones@...aro.org>,
        "sboyd@...nel.org" <sboyd@...nel.org>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>
Subject: Re: [PATCH 0/9] Drop ROHM BD70528 support


On Tue, 2021-05-25 at 13:13 +0300, Matti Vaittinen wrote:
> Drop ROHM BD70528 support
> 
> Unfortunately there has not been a big demand for ROHM BD70528
> IC. The few users I know control PMIC from separate M4-core,
> which is not running Linux. I am not aware of any users of this
> Linux driver.
> 
> While I did really like this IC and writing the drivers for it,
> seems like these drivers are becoming useless burden. So, I see
> no point in maintaining them. Let's just drop the drivers if
> there is no objections to this series. :(
> 
> Few notes:
> 
> The GPIO, regulator, power-supply and watchdog drivers should be
> only used on BD70528 and depend on the BD70528 MFD Kconfig. I guess
> the removal can be independently merged to the respective subsystems.
> 
> The BD70528 RTC driver is still used by BD71815 and BD71828 -
> but the watchdog-hack can be removed and driver is greatly
> simplified. However, it's worth noting that there is dependency
> from the BD70528 RTC driver to the header files - thus the
> RTC driver changes should be merged before MFD changes. Also the
> CLK driver remains in use and needs the BD70528 IC-type.
> 
> As a final note - Few improvements/fixes were just applied to the
> regulator tree so this series is likely to conflict. Some fixes
> were also added to RTC Kconfig - which means also the RTC tree
> may have conflicts. Please let me know if you wish me to rebase
> this series or those patches.

As shortly discussed with Alexandre here:
https://lore.kernel.org/lkml/YKz25PDL2Z6vgqJv@piout.net/

The easiest way to drop the support without breaking the dependencies
and without introducing conflicts is to drop support from sub-devices
in one cycle and the MFD only at next cycle. So Lee, please ignore the
MFD part for now.

I'll rebase the RTC and regulator patches to RTC and regulator trees
and send them as individual patches to Mark and Alexandre. I think the
other sub-device patches and the DT bindings patch should apply cleanly
to the respective trees. Please let me know if this does not work for
you.

I'll re-spin the MFD portion during the next cycle.

Best Regards
	Matti Vaittinen