linux-kernel - Re: [PATCH] drm/bridge: DRM_CROS_EC_ANX7688 should depend on I2C_CROS_EC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d728f168-8e36-44e4-0d9a-a52572ed1c1b@collabora.com>
Date:   Thu, 27 May 2021 13:07:08 +0200
From:   Enric Balletbo i Serra <enric.balletbo@...labora.com>
To:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Andrzej Hajda <a.hajda@...sung.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Robert Foss <robert.foss@...aro.org>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Jonas Karlman <jonas@...boo.se>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Hsin-Yi Wang <hsinyi@...omium.org>,
        Nicolas Boichat <drinkcat@...omium.org>
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/bridge: DRM_CROS_EC_ANX7688 should depend on
 I2C_CROS_EC_TUNNEL

Hi Geert,

Thank you for your patch.

On 26/5/21 9:50, Geert Uytterhoeven wrote:
> The ChromeOS EC ANX7688 bridge is connected to a ChromeOS Embedded
> Controller, and is accessed using I2C tunneling through the Embedded
> Controller.  Hence add a dependency on I2C_CROS_EC_TUNNEL, to prevent
> asking the user about this driver when configuring a kernel without
> support for the ChromeOS EC tunnel I2C bus.
> 
> Fixes: 44602b10d7f2a5f7 ("drm/bridge: Add ChromeOS EC ANX7688 bridge driver support")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Reviewed-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>

> ---
>  drivers/gpu/drm/bridge/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 7e7f28eb954661e2..c96e4b38d1d34ee6 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -53,6 +53,7 @@ config DRM_CHRONTEL_CH7033
>  config DRM_CROS_EC_ANX7688
>  	tristate "ChromeOS EC ANX7688 bridge"
>  	depends on OF
> +	depends on I2C_CROS_EC_TUNNEL || COMPILE_TEST
>  	select DRM_KMS_HELPER
>  	select REGMAP_I2C
>  	help
>