linux-kernel - Re: [PATCH 1/1] spi-sun6i: Fix chipselect/clock bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 May 2021 13:39:20 +0200
From:   Ralf Schlatterbeck <rsc@...tux.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     Andre Przywara <andre.przywara@....com>,
        Maxime Ripard <mripard@...nel.org>,
        Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        linux-spi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Mirko Vogt <mirko-dev|linux@...l.de>
Subject: Re: [PATCH 1/1] spi-sun6i: Fix chipselect/clock bug

On Tue, May 25, 2021 at 03:35:51PM +0100, Mark Brown wrote:
> On Fri, May 21, 2021 at 10:19:13PM +0200, Ralf Schlatterbeck wrote:
> > From: Mirko Vogt <mirko-dev|linux@...l.de>
> > 
> > The current sun6i SPI implementation initializes the transfer too early,
> > resulting in SCK going high before the transfer. When using an additional
> > (gpio) chipselect with sun6i, the chipselect is asserted at a time when
> > clock is high, making the SPI transfer fail.
> 
> Please don't send new patches in reply to old threads, this makes
> it hard to follow what is going on and creates confusion as to
> what the current version of things is and means things can easily
> get missed if the earlier thread gets discarded - this goes along
> with the thing Andre mentioned about flagging the version of the
> patch in the subject line.

OK, let me know if I should repost in new thread with increased version
number in the subject.

Thanks,
Ralf
-- 
Dr. Ralf Schlatterbeck                  Tel:   +43/2243/26465-16
Open Source Consulting                  www:   www.runtux.com
Reichergasse 131, A-3411 Weidling       email: office@...tux.com