linux-kernel - Re: [PATCH 1/1] sched/topology: Fix a spelling mistake in error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ee11a1b4-04b5-8768-f26b-cf5310b77b3c@huawei.com>
Date:   Thu, 27 May 2021 09:57:40 +0800
From:   "Leizhen (ThunderTown)" <thunder.leizhen@...wei.com>
To:     Ingo Molnar <mingo@...nel.org>
CC:     Randy Dunlap <rdunlap@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Juri Lelli <juri.lelli@...hat.com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
        "Daniel Bristot de Oliveira" <bristot@...hat.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] sched/topology: Fix a spelling mistake in error
 message



On 2021/5/26 14:52, Ingo Molnar wrote:
> 
> * Leizhen (ThunderTown) <thunder.leizhen@...wei.com> wrote:
> 
>>
>>
>> On 2021/5/26 10:32, Randy Dunlap wrote:
>>> On 5/25/21 7:18 PM, Zhen Lei wrote:
>>>> The misspelled word 'borken' should be 'broken'.
>>>>
>>>> Fixes: 6ae72dff3759 ("sched: Robustify topology setup")
>>>> Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>
>>>> ---
>>>>  kernel/sched/topology.c | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
>>>> index 55a0a243e871..80295e224442 100644
>>>> --- a/kernel/sched/topology.c
>>>> +++ b/kernel/sched/topology.c
>>>> @@ -1937,7 +1937,7 @@ static struct sched_domain *build_sched_domain(struct sched_domain_topology_leve
>>>>  
>>>>  		if (!cpumask_subset(sched_domain_span(child),
>>>>  				    sched_domain_span(sd))) {
>>>> -			pr_err("BUG: arch topology borken\n");
>>>> +			pr_err("BUG: arch topology broken\n");
>>>
>>> Would "borked" or "b0rken" be clearer?
>>
>> These two words don't seem to exist at all. Linux is an open-source
>> code for the world, so it's better to use a more common word.
> 
> What?
> 
> Please google:
> 
>     "borken" meaning

Hi, Ingo and Randy:
  I apologize to you both. In fact, I googled 'borken' before posting this patch.
But the result is: Borken is a German town. But I really didn't Google "borked"
and "b0rken", I just looked it up with an English dictionary software, but it
doesn't exist.
  As Randy's advice, it would be better to use "borked". At least it doesn't feel
like the 'r' and 'o' in "broken" are written in reverse order. There is no semantic
error in using "broken" in this sentence.

> 
> Please stop these pointless patches.

He who does not know is not guilty.

> 
> Thanks,
> 
> 	Ingo
> 
> .
>