linux-kernel - Re: [PATCH 2/3] watchdog: sama5d4_wdt: add support for sama7g5-wdt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f9b29938-c9a0-4cb0-cc0f-e9c83c5c0c27@microchip.com>
Date:   Thu, 27 May 2021 14:09:51 +0200
From:   Nicolas Ferre <nicolas.ferre@...rochip.com>
To:     Eugen Hristev <eugen.hristev@...rochip.com>,
        <wim@...ux-watchdog.org>, <linux@...ck-us.net>,
        <robh+dt@...nel.org>
CC:     <linux-watchdog@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] watchdog: sama5d4_wdt: add support for sama7g5-wdt

On 27/05/2021 at 12:01, Eugen Hristev wrote:
> Add support for compatible sama7g5-wdt.
> The sama7g5 wdt is the same hardware block as on sam9x60.
> Adapt the driver to use the sam9x60/sama7g5 variant if either
> of the two compatibles are selected (sam9x60-wdt/sama7g5-wdt).
> 
> Signed-off-by: Eugen Hristev <eugen.hristev@...rochip.com>

Looks good to me:
Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

Thanks, best regards,
   Nicolas

> ---
>   drivers/watchdog/sama5d4_wdt.c | 10 ++++++++--
>   1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/watchdog/sama5d4_wdt.c b/drivers/watchdog/sama5d4_wdt.c
> index e5d11d6a2600..ec20ad4e534f 100644
> --- a/drivers/watchdog/sama5d4_wdt.c
> +++ b/drivers/watchdog/sama5d4_wdt.c
> @@ -268,8 +268,10 @@ static int sama5d4_wdt_probe(struct platform_device *pdev)
>   	wdd->min_timeout = MIN_WDT_TIMEOUT;
>   	wdd->max_timeout = MAX_WDT_TIMEOUT;
>   	wdt->last_ping = jiffies;
> -	wdt->sam9x60_support = of_device_is_compatible(dev->of_node,
> -						       "microchip,sam9x60-wdt");
> +
> +	if (of_device_is_compatible(dev->of_node, "microchip,sam9x60-wdt") ||
> +	    of_device_is_compatible(dev->of_node, "microchip,sama7g5-wdt"))
> +		wdt->sam9x60_support = true;
>   
>   	watchdog_set_drvdata(wdd, wdt);
>   
> @@ -329,6 +331,10 @@ static const struct of_device_id sama5d4_wdt_of_match[] = {
>   	{
>   		.compatible = "microchip,sam9x60-wdt",
>   	},
> +	{
> +		.compatible = "microchip,sama7g5-wdt",
> +	},
> +
>   	{ }
>   };
>   MODULE_DEVICE_TABLE(of, sama5d4_wdt_of_match);
> 


-- 
Nicolas Ferre