linux-kernel - [PATCH v2] MOUSE_ATARI: fix kconfig unmet dependency warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 26 May 2021 17:12:51 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     linux-kernel@...r.kernel.org
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        Michael Schmitz <schmitz@...ian.org>,
        Roman Zippel <zippel@...ux-m68k.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        linux-input@...r.kernel.org, linux-m68k@...ts.linux-m68k.org,
        Michael Schmitz <schmitzmic@...il.com>
Subject: [PATCH v2] MOUSE_ATARI: fix kconfig unmet dependency warning

Since the code for ATARI_KBD_CORE does not use drivers/input/keyboard/
code, just move ATARI_KBD_CORE to arch/m68k/Kconfig.machine to remove
this dependency.

Removes this kconfig warning:

WARNING: unmet direct dependencies detected for ATARI_KBD_CORE
  Depends on [n]: !UML && INPUT [=y] && INPUT_KEYBOARD [=n]
  Selected by [y]:
  - MOUSE_ATARI [=y] && !UML && INPUT [=y] && INPUT_MOUSE [=y] && ATARI [=y]

Fixes: c04cb856e20a ("m68k: Atari keyboard and mouse support.")
Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Cc: Michael Schmitz <schmitz@...ian.org>
Cc: Roman Zippel <zippel@...ux-m68k.org>
Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: linux-input@...r.kernel.org
Cc: linux-m68k@...ts.linux-m68k.org
Suggested-by: Geert Uytterhoeven <geert@...ux-m68k.org>
Suggested-by: Michael Schmitz <schmitzmic@...il.com>
---
v2: move the symbol outside of INPUT_KEYBOARD (Geert) -- all the way
    to Kconfig.machine (Michael). Thanks.

 arch/m68k/Kconfig.machine      |    3 +++
 drivers/input/keyboard/Kconfig |    3 ---
 2 files changed, 3 insertions(+), 3 deletions(-)

--- linux-next-20210525.orig/arch/m68k/Kconfig.machine
+++ linux-next-20210525/arch/m68k/Kconfig.machine
@@ -25,6 +25,9 @@ config ATARI
 	  this kernel on an Atari, say Y here and browse the material
 	  available in <file:Documentation/m68k>; otherwise say N.
 
+config ATARI_KBD_CORE
+	bool
+
 config MAC
 	bool "Macintosh support"
 	depends on MMU
--- linux-next-20210525.orig/drivers/input/keyboard/Kconfig
+++ linux-next-20210525/drivers/input/keyboard/Kconfig
@@ -67,9 +67,6 @@ config KEYBOARD_AMIGA
 	  To compile this driver as a module, choose M here: the
 	  module will be called amikbd.
 
-config ATARI_KBD_CORE
-	bool
-
 config KEYBOARD_APPLESPI
 	tristate "Apple SPI keyboard and trackpad"
 	depends on ACPI && EFI