linux-kernel - Re: [PATCH] dt-bindings: connector: Replace BIT macro with generic bit ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGZ6i=1zVegu_eUJrGwWYsfyVG6v3N4pDY4vwHNShykxf7K3aQ@mail.gmail.com>
Date:   Thu, 27 May 2021 20:12:30 +0800
From:   Kyle Tso <kyletso@...gle.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Rob Herring <robh+dt@...nel.org>,
        Badhri Jagan Sridharan <badhri@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH] dt-bindings: connector: Replace BIT macro with generic
 bit ops

On Thu, May 27, 2021 at 6:21 PM Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Thu, May 27, 2021 at 06:13:45PM +0800, Kyle Tso wrote:
> > BIT macro is not supported in dt-bindings. Replace it with generic bit
> > operations.
>
> Why isn't the BIT macro supported there?  How are we going to "remember"
> that I should not take patches that use this #define in that location?

I rephrased the commit message in v2

thanks,
Kyle

>
> thanks,
>
> greg k-h