linux-kernel - Re: [PATCH v2] dt-bindings: connector: Replace BIT macro with generic bit ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YK+TZOAlc6zYRE0v@kroah.com>
Date:   Thu, 27 May 2021 14:41:08 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Kyle Tso <kyletso@...gle.com>
Cc:     heikki.krogerus@...ux.intel.com, robh+dt@...nel.org,
        badhri@...gle.com, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v2] dt-bindings: connector: Replace BIT macro with
 generic bit ops

On Thu, May 27, 2021 at 08:10:29PM +0800, Kyle Tso wrote:
> BIT macro is not defined. Replace it with generic bit operations.
> 
> Fixes: 630dce2810b9 ("dt-bindings: connector: Add SVDM VDO properties")
> Signed-off-by: Kyle Tso <kyletso@...gle.com>
> ---
> Changes since v1:
> - re-word the commit message
> 
>  include/dt-bindings/usb/pd.h | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/include/dt-bindings/usb/pd.h b/include/dt-bindings/usb/pd.h
> index fef3ef65967f..cb70b4ceedde 100644
> --- a/include/dt-bindings/usb/pd.h
> +++ b/include/dt-bindings/usb/pd.h
> @@ -163,10 +163,10 @@
>  #define UFP_VDO_VER1_2		2
>  
>  /* Device Capability */
> -#define DEV_USB2_CAPABLE	BIT(0)
> -#define DEV_USB2_BILLBOARD	BIT(1)
> -#define DEV_USB3_CAPABLE	BIT(2)
> -#define DEV_USB4_CAPABLE	BIT(3)
> +#define DEV_USB2_CAPABLE	(1 << 0)
> +#define DEV_USB2_BILLBOARD	(1 << 1)
> +#define DEV_USB3_CAPABLE	(1 << 2)
> +#define DEV_USB4_CAPABLE	(1 << 3)

Why not just include the proper .h file instead?