linux-kernel - Re: [PATCH] regulator: fan53555: add back tcs4526

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YK+ZMdD+7uqQwCow@sirena.org.uk>
Date:   Thu, 27 May 2021 14:05:53 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Ezequiel Garcia <ezequiel@...labora.com>
Cc:     Rudi Heitbaum <rudi@...tbaum.com>,
        Peter Geis <pgwipeout@...il.com>, devicetree@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        chenjh@...k-chips.com
Subject: Re: [PATCH] regulator: fan53555: add back tcs4526

On Thu, May 27, 2021 at 08:51:27AM -0300, Ezequiel Garcia wrote:
> On Thu, 2021-05-27 at 10:59 +0000, Rudi Heitbaum wrote:

> > +               reg = <0x1c>;
> > +               vin-supply = <&vcc5v0_sys>;
> > +               regulator-compatible = "fan53555-reg";

> I can be wrong, but I think regulator-compatible is deprecated.

Yes.

> > +               regulator-ramp-delay = <1000>;
> > +               fcs,suspend-voltage-selector = <1>;
> > +               regulator-always-on;
> > +               regulator-boot-on;

> Just out of curiosity, is regulator-boot-on really needed for the GPU?

It should only be used if it's not possible to read the state of
the regulator enable from the hardware.

Please delete unneeded context from mails when replying.  Doing this
makes it much easier to find your reply in the message, helping ensure
it won't be missed by people scrolling through the irrelevant quoted
material.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)