linux-kernel - Re: linux-next: build failure after merge of the hid tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 May 2021 18:52:36 +0530
From:   Naresh Kamboju <naresh.kamboju@...aro.org>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     Jiri Kosina <jikos@...nel.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the hid tree

FYI,

On Thu, 27 May 2021 at 13:56, Hans de Goede <hdegoede@...hat.com> wrote:
>
> Hi,
>
> On 5/27/21 10:14 AM, Jiri Kosina wrote:
> > On Thu, 27 May 2021, Stephen Rothwell wrote:
> >
> >> After merging the hid tree, today's linux-next build (x86_64
> >> modules_install (on an allmodconfig build)) failed like this:
> >>
> >> depmod: ERROR: Cycle detected: hid -> usbhid -> hid
> >> depmod: ERROR: Found 2 modules in dependency cycles!

LKFT build system also found two types of build errors while building for arm
on today's Linux next-20210527 tag.

1)
arm-linux-gnueabihf-ld: drivers/hid/hid-core.o: in function `hid_is_usb_device':
hid-core.c:(.text+0x1f4): undefined reference to `usb_hid_driver'
make[1]: *** [/builds/linux/Makefile:1252: vmlinux] Error 1


2)
INSTALL_MOD_PATH=/home/tuxbuild/.cache/tuxmake/builds/current/modinstall
depmod: ERROR: Cycle detected: hid -> usbhid -> hid
depmod: ERROR: Found 2 modules in dependency cycles!
make[1]: *** [/builds/linux/Makefile:1875: modules_install] Error 1


> >>
> >> I could not easily figure out what caused this (it may not be the hid
> >> tree, but probably is), so all I could do was leave it broken.
> >
> > This is caused by Hans' patches (CCed). I will be dropping those today, as
> > the proper fix needs a bit more of rework.
>
> Ack, sorry about the trouble these patches are causing.

Thanks for investigating the root cause.

- Naresh