linux-kernel - Re: [PATCH] dt-bindings: PCI: ti,am65: Convert PCIe host/endpoint mode dt-bindings to YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 27 May 2021 09:23:27 -0500
From:   Rob Herring <robh@...nel.org>
To:     Kishon Vijay Abraham I <kishon@...com>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>, linux-kernel@...r.kernel.org,
        Nishanth Menon <nm@...com>, devicetree@...r.kernel.org,
        Lokesh Vutla <lokeshvutla@...com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        linux-pci@...r.kernel.org, Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH] dt-bindings: PCI: ti,am65: Convert PCIe host/endpoint mode dt-bindings to YAML

On Wed, 26 May 2021 19:17:08 +0530, Kishon Vijay Abraham I wrote:
> Convert PCIe host/endpoint mode dt-bindings for TI's AM65/Keystone SoC
> to YAML binding.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@...com>
> ---
>  .../devicetree/bindings/pci/pci-keystone.txt  | 115 ------------------
>  .../bindings/pci/ti,am65-pci-ep.yaml          |  80 ++++++++++++
>  .../bindings/pci/ti,am65-pci-host.yaml        | 105 ++++++++++++++++
>  3 files changed, 185 insertions(+), 115 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/pci/pci-keystone.txt
>  create mode 100644 Documentation/devicetree/bindings/pci/ti,am65-pci-ep.yaml
>  create mode 100644 Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/intel-gw-pcie.example.dt.yaml: pcie@...00000: compatible: 'oneOf' conditional failed, one must be fixed:
	['intel,lgm-pcie', 'snps,dw-pcie'] is too long
	Additional items are not allowed ('snps,dw-pcie' was unexpected)
	'ti,am654-pcie-rc' was expected
	'ti,keystone-pcie' was expected
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/intel-gw-pcie.example.dt.yaml: pcie@...00000: reg: [[3504340992, 4096], [3523215360, 8388608], [3500412928, 4096]] is too short
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/intel-gw-pcie.example.dt.yaml: pcie@...00000: reg-names:0: 'app' was expected
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/intel-gw-pcie.example.dt.yaml: pcie@...00000: reg-names:1: 'dbics' was expected
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/intel-gw-pcie.example.dt.yaml: pcie@...00000: reg-names:2: 'config' was expected
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/intel-gw-pcie.example.dt.yaml: pcie@...00000: reg-names: ['dbi', 'config', 'app'] is too short
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/intel-gw-pcie.example.dt.yaml: pcie@...00000: 'ti,syscon-pcie-id' is a required property
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/intel-gw-pcie.example.dt.yaml: pcie@...00000: 'ti,syscon-pcie-mode' is a required property
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml

See https://patchwork.ozlabs.org/patch/1484053

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.