linux-kernel - Re: [External] [PATCH v1] hugetlb: pass head page to remove_hugetlb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMZfGtXgZ1R9BSE5=sgxKwHLUdo1zCmr4QBHhncpUxJVpzfi-Q@mail.gmail.com>
Date:   Thu, 27 May 2021 10:43:44 +0800
From:   Muchun Song <songmuchun@...edance.com>
To:     Naoya Horiguchi <nao.horiguchi@...il.com>
Cc:     Linux Memory Management List <linux-mm@...ck.org>,
        Mike Kravetz <mike.kravetz@...cle.com>,
        Michal Hocko <mhocko@...e.com>,
        Oscar Salvador <osalvador@...e.de>,
        Andrew Morton <akpm@...ux-foundation.org>,
        David Hildenbrand <david@...hat.com>,
        Naoya Horiguchi <naoya.horiguchi@....com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [External] [PATCH v1] hugetlb: pass head page to remove_hugetlb_page()

On Thu, May 27, 2021 at 7:53 AM Naoya Horiguchi <nao.horiguchi@...il.com> wrote:
>
> From: Naoya Horiguchi <naoya.horiguchi@....com>
>
> When memory_failure() or soft_offline_page() is called on a tail page of
> some hugetlb page, "BUG: unable to handle page fault" error can be
> triggered.
>
> remove_hugetlb_page() dereferences page->lru, so it's assumed that the
> page points to a head page, but one of the caller,
> dissolve_free_huge_page(), provides remove_hugetlb_page() with 'page'
> which could be a tail page.  So pass 'head' to it, instead.
>
> Fixes: 6eb4e88a6d27 ("hugetlb: create remove_hugetlb_page() to separate functionality")
> Signed-off-by: Naoya Horiguchi <naoya.horiguchi@....com>

Thanks Naoya!

Reviewed-by: Muchun Song <songmuchun@...edance.com>