linux-kernel - RE: [PATCH 1/2] dt-bindings: pinctrl: Add bindings for Intel Keembay pinctrl driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BL3PR11MB56995AD9237CBA2BD3F9ABC6C4239@BL3PR11MB5699.namprd11.prod.outlook.com>
Date:   Thu, 27 May 2021 15:04:17 +0000
From:   "D, Lakshmi Sowjanya" <lakshmi.sowjanya.d@...el.com>
To:     Linus Walleij <linus.walleij@...aro.org>
CC:     "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        "Raja Subramanian, Lakshmi Bai" 
        <lakshmi.bai.raja.subramanian@...el.com>,
        "Saha, Tamal" <tamal.saha@...el.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: RE: [PATCH 1/2] dt-bindings: pinctrl: Add bindings for Intel Keembay
 pinctrl driver

Hi Linus Walleij

Thanks for the review.

Regards,
Lakshmi

-----Original Message-----
From: Linus Walleij <linus.walleij@...aro.org> 
Sent: Thursday, May 27, 2021 4:12 PM
To: D, Lakshmi Sowjanya <lakshmi.sowjanya.d@...el.com>
Cc: open list:GPIO SUBSYSTEM <linux-gpio@...r.kernel.org>; linux-kernel <linux-kernel@...r.kernel.org>; Raja Subramanian, Lakshmi Bai <lakshmi.bai.raja.subramanian@...el.com>; Saha, Tamal <tamal.saha@...el.com>
Subject: Re: [PATCH 1/2] dt-bindings: pinctrl: Add bindings for Intel Keembay pinctrl driver

Hi Lakshmi,

some more review of the bindings!

On Mon, May 24, 2021 at 11:26 AM <lakshmi.sowjanya.d@...el.com> wrote:

> +properties:
> +  compatible:
> +    const: intel,keembay-pinctrl
> +
> +  reg:
> +    maxItems: 2
> +
> +  gpio-controller: true
> +
> +  '#gpio-cells':
> +    const: 2

The code uses "num-gpios" but should be using "ngpios" which is the standard.
-- Will update in the next version

> +  interrupts:
> +    description:
> +      Specifies the interrupt lines to be used by the controller.
> +    maxItems: 8

We need to figure out how these interrupt assign to GPIOs, and it is relevant to write that already here, om the description. It is fine if the same info is duplicated in the driver.
-- Shall document it properly in next version

> +patternProperties:
> +  '^.$':
> +    type: object

Certainly these nodes can have a strict name?
--I will change the name accordingly.

Use includes for checking standard attributes:
$ref: pinmux-node.yaml#
$ref: pincfg-node.yaml#
--I will use the suggested includes.

> +    description:
> +      Child nodes can be specified to contain pin configuration information,
> +      which can then be utilized by pinctrl client devices.
> +      The following properties are supported.
> +
> +    properties:
> +      pins:
> +        description: |
> +          The name(s) of the pins to be configured in the child node.
> +          Supported pin names are "GPIO0" up to "GPIO79".
(...)
> +      bias-disable:
> +        type: boolean

Using $ref: pincfg-node.yaml# this becomes
bias-disable: true
etc.
--Thanks! Will update in next version.

> +      drive-strength:
> +        enum: [2, 4, 8, 12]

This needs to be specified though.

> +      slew-rate:
> +        description: |
> +         0: Fast
> +         1: Slow
> +        enum: [0, 1]

And this.
--Will specify the enums in next version.


Yours,
Linus Walleij