linux-kernel - [PATCH] ide: Remove unused variable ide_media_proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 28 May 2021 00:07:03 +0900
From:   Hyeonggon Yoo <42.hyeyoo@...il.com>
To:     "David S. Miller" <davem@...emloft.net>
Cc:     linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] ide: Remove unused variable ide_media_proc_fops

When compiled with option W=1, compiler complained that
ide_media_proc_fops is unused.

in commit ec7d9c9ce897 ("ide: replace ->proc_fops with ->proc_show"),
changed proc_fops to proc_show. So this is not needed anymore.

Also remove function ide_media_proc_open that is only referenced
by ide_media_proc_fops.

Fixes: ec7d9c9ce897("ide: replace ->proc_fops with ->proc_show")
Signed-off-by: Hyeonggon Yoo <42.hyeyoo@...il.com>
---
 drivers/ide/ide-proc.c | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/drivers/ide/ide-proc.c b/drivers/ide/ide-proc.c
index 15c17f3781ee..34bed14f88c7 100644
--- a/drivers/ide/ide-proc.c
+++ b/drivers/ide/ide-proc.c
@@ -449,19 +449,6 @@ static int ide_media_proc_show(struct seq_file *m, void *v)
 	return 0;
 }

-static int ide_media_proc_open(struct inode *inode, struct file *file)
-{
-	return single_open(file, ide_media_proc_show, PDE_DATA(inode));
-}
-
-static const struct file_operations ide_media_proc_fops = {
-	.owner		= THIS_MODULE,
-	.open		= ide_media_proc_open,
-	.read		= seq_read,
-	.llseek		= seq_lseek,
-	.release	= single_release,
-};
-
 static ide_proc_entry_t generic_drive_entries[] = {
 	{ "driver",	S_IFREG|S_IRUGO,	 ide_driver_proc_show	},
 	{ "identify",	S_IFREG|S_IRUSR,	 ide_identify_proc_show	},
-- 
2.25.1