linux-kernel - Re: [PATCH] drm/msm/dpu: remove unused variable cmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADLLry7xtt60wNqD4ZkcLByqEuyBpdO4VYjGjbrTMLsG1ACdcw@mail.gmail.com>
Date:   Thu, 27 May 2021 12:00:12 +0900
From:   Austin Kim <austindh.kim@...il.com>
To:     robdclark@...il.com, sean@...rly.run, airlied@...ux.ie,
        Daniel Vetter <daniel@...ll.ch>,
        angelogioacchino.delregno@...ainline.org,
        dmitry.baryshkov@...aro.org
Cc:     linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        freedreno@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        김동현 <austindh.kim@...il.com>
Subject: Re: [PATCH] drm/msm/dpu: remove unused variable cmd_enc

2021년 5월 21일 (금) 오후 1:16, Austin Kim <austindh.kim@...il.com>님이 작성:
>
> After the call to to_dpu_encoder_phys_cmd() is made,
> 'cmd_enc' is not used. Where to_dpu_encoder_phys_cmd() is simply replaced with
> container_of(x, struct dpu_encoder_phys_cmd, base) by compiler.
>
> So it had better remove W=1 kernel build warning(s):
>
>   drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c: In function
>  ‘dpu_encoder_phys_cmd_wait_for_commit_done’:
>   drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c:688:31: warning:
>   variable ‘cmd_enc’ set but not used
>
> Signed-off-by: Austin Kim <austindh.kim@...il.com>
> ---
>  drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
> index b2be39b9144e..088900841bf8 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
> @@ -685,10 +685,6 @@ static int dpu_encoder_phys_cmd_wait_for_tx_complete(
>  static int dpu_encoder_phys_cmd_wait_for_commit_done(
>                 struct dpu_encoder_phys *phys_enc)
>  {
> -       struct dpu_encoder_phys_cmd *cmd_enc;
> -
> -       cmd_enc = to_dpu_encoder_phys_cmd(phys_enc);
> -
>         /* only required for master controller */
>         if (!dpu_encoder_phys_cmd_is_master(phys_enc))
>                 return 0;
> --
> 2.20.1
>

If you are available, would you please review this patch.

BR,
Austin Kim