linux-kernel - Re: [PATCH] dt-bindings: serial: Move omap-serial.txt to YAML schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YLCWS/+TwSs8HhRG@atomide.com>
Date:   Fri, 28 May 2021 10:05:47 +0300
From:   Tony Lindgren <tony@...mide.com>
To:     Grygorii Strashko <grygorii.strashko@...com>
Cc:     Vignesh Raghavendra <vigneshr@...com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh+dt@...nel.org>, linux-serial@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-omap@...r.kernel.org,
        Linux ARM Mailing List <linux-arm-kernel@...ts.infradead.org>,
        Dario Binacchi <dariobin@...ero.it>
Subject: Re: [PATCH] dt-bindings: serial: Move omap-serial.txt to YAML schema

* Grygorii Strashko <grygorii.strashko@...com> [210527 17:49]:
> 
> 
> On 27/05/2021 19:56, Vignesh Raghavendra wrote:
> > Convert serial-omap.txt to YAML schema for better checks and documentation.
> > 
> > Signed-off-by: Vignesh Raghavendra <vigneshr@...com>
> > ---
> >   .../bindings/serial/omap_serial.txt           |  40 ------
> >   .../bindings/serial/ti,omap4-uart.yaml        | 116 ++++++++++++++++++
> >   2 files changed, 116 insertions(+), 40 deletions(-)
> >   delete mode 100644 Documentation/devicetree/bindings/serial/omap_serial.txt
> >   create mode 100644 Documentation/devicetree/bindings/serial/ti,omap4-uart.yaml
> 
> Why omap4? Seems ti,omap-uart.yaml is more suitable.

Additionally omap-serial should be deprecated in favor of 8250_omap and
omap-serial not used at all in general.

It seems some folks still stick to omap-serial for legacy reasons when
using an old .config. That's easy to fix by just changing inittab to
use ttyS instead of ttyO, the kernel cmdline is already fixed up on
init to use ttyS, but might as well update the bootloader cmdline too.

But why do we even allow using this driver on newer SoCs when we have
already planned to deprecate omap-serial.c years before the new SoCs?

I suggest we make omap-serial deprecated for all SoCs, and not even
allow it for am6, omap-serial.c only lists these:

        { .compatible = "ti,omap2-uart" },
        { .compatible = "ti,omap3-uart" },
        { .compatible = "ti,omap4-uart" },

And folks are also using it for some rs485 cases that should just be
really fixed for 8250_omap instead.. Adding Dario to Cc because of
these omap-serial patches:

e2a5e8448e73 ("serial: omap: fix rs485 half-duplex filtering")
45f6b6db53c8 ("serial: omap: don't disable rs485 if rts gpio is missing")

Dario, why not use 8250_omap instead?

Regards,

Tony