linux-kernel - Re: [PATCH 2/2] drivers/firmware: consolidate EFI framebuffer setup for all arches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c6c6b686-6e13-2f1a-0310-b558428304c1@redhat.com>
Date:   Fri, 28 May 2021 10:03:04 +0200
From:   Javier Martinez Canillas <javierm@...hat.com>
To:     Thomas Zimmermann <tzimmermann@...e.de>,
        linux-kernel@...r.kernel.org
Cc:     Albert Ou <aou@...s.berkeley.edu>, David Airlie <airlied@...ux.ie>,
        Catalin Marinas <catalin.marinas@....com>,
        Russell King <linux@...linux.org.uk>,
        dri-devel@...ts.freedesktop.org,
        Hans de Goede <hdegoede@...hat.com>,
        linux-efi@...r.kernel.org, Palmer Dabbelt <palmer@...belt.com>,
        Peter Robinson <pbrobinson@...il.com>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        linux-riscv@...ts.infradead.org, Will Deacon <will@...nel.org>,
        Ard Biesheuvel <ardb@...nel.org>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/2] drivers/firmware: consolidate EFI framebuffer setup
 for all arches

Hello Thomas,

On 5/22/21 7:14 AM, Thomas Zimmermann wrote:

[snip]

>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -127,6 +127,7 @@ config ARM
>>   	select PERF_USE_VMALLOC
>>   	select RTC_LIB
>>   	select SET_FS
>> +	select SYSFB
> 
> Don't select this as part of the architecture. Rather make an option for 
> SYSFB that depends in the architectures that supports it.
>

Thanks a lot for the suggestion! I did this by making SYSFB's Kconfig option
to be default y and depends on the supported architectures as you mentioned.

This not only is a cleaner approach but also will allow to not touch all the
architectures platform code.

I'll wait for a few more days in case someone else has feedback and post a v2.
 
> Best regards
> Thomas
> 
> 

Best regards,
-- 
Javier Martinez Canillas
Software Engineer
New Platform Technologies Enablement team
RHEL Engineering