linux-kernel - Re: [PATCH] ARM: simplify the build rule of mach-types.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdb-CsQtaiRjUWsimSmBw8tAgvr_ET1BS47rsVxd-eY0VA@mail.gmail.com>
Date:   Fri, 28 May 2021 10:23:58 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     patches@....linux.org.uk,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Russell King <linux@...linux.org.uk>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] ARM: simplify the build rule of mach-types.h

On Fri, May 28, 2021 at 5:52 AM Masahiro Yamada <masahiroy@...nel.org> wrote:

> The directory of mach-types.h is created a couple of lines above:
>
>   _dummy := $(shell [ -d '$(kapi)' ] || mkdir -p '$(kapi)') \
>
> The 'mkdir -p' command is redundant.
>
> scripts/Kbuild.include defines real-prereqs as a shorthand for
> $(filter-out $(PHONY),$^). Let's use it to simplify the code.
>
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Can you put this into Russell's patch tracker or shall I sign
it off and put it there?

Yours,
Linus Walleij