linux-kernel - Re: [PATCH v1] kbuild: Disable compile testing if HAVE_LEGACY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a0hZGEOh0jckDvt-386KopCCL09RM6hv4qAUie31LDSTQ@mail.gmail.com>
Date:   Fri, 28 May 2021 11:27:54 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Dmitry Osipenko <digetx@...il.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Tony Lindgren <tony@...mide.com>,
        Paul Burton <paul.burton@...s.com>,
        John Crispin <john@...ozen.org>,
        "open list:BROADCOM NVRAM DRIVER" <linux-mips@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        linux-m68k <linux-m68k@...ts.linux-m68k.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-tegra <linux-tegra@...r.kernel.org>,
        linux-clk <linux-clk@...r.kernel.org>,
        "open list:TI ETHERNET SWITCH DRIVER (CPSW)" 
        <linux-omap@...r.kernel.org>
Subject: Re: [PATCH v1] kbuild: Disable compile testing if HAVE_LEGACY_CLK enabled

On Wed, May 26, 2021 at 2:39 AM Randy Dunlap <rdunlap@...radead.org> wrote:
> On 5/25/21 2:29 PM, Dmitry Osipenko wrote:
> > 25.05.2021 15:19, Geert Uytterhoeven пишет:
> If you are messing around with HAVE_LEGACY_CLK and COMMON_CLK
> and don't mind, please have a look at this report from
> 'kernel test robot':
>   https://lore.kernel.org/lkml/202103162301.oomY9NwI-lkp@intel.com/
>
>
> Maybe this one is more MIPS-specific. I dunno.
> I tried to come up with a patch for it and failed.
>
> I will be happy to built-test any patches that you come up with.
>
> Maybe I have just looked at this too long...

This is exactly the case that Dmitry is trying to solve. The problem
is that bcm63xx
and lantiq set CONFIG_HAVE_LEGACY_CLK but lack the clk_set_parent()
and clk_get_parent() functions. We could add the same stubs for these
two that we have for the other legacy clk implementations, or rework the
handling of legacy clocks completely.

       Arnd