linux-kernel - Re: [PATCH 03/15] leds: led-class: Fix incorrectly documented param 'dev'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YLDBnIx/4L/O0oa0@ada.ifak-system.com>
Date:   Fri, 28 May 2021 12:10:36 +0200
From:   Alexander Dahl <ada@...rsis.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     linux-kernel@...r.kernel.org, Pavel Machek <pavel@....cz>,
        John Lenz <lenz@...wisc.edu>,
        Richard Purdie <rpurdie@...nedhand.com>,
        linux-leds@...r.kernel.org
Subject: Re: [PATCH 03/15] leds: led-class: Fix incorrectly documented param
 'dev'

Hello,

Am Fri, May 28, 2021 at 10:06:17AM +0100 schrieb Lee Jones:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/leds/led-class.c:521: warning: Function parameter or member 'dev' not described in 'devm_led_classdev_unregister'
>  drivers/leds/led-class.c:521: warning: Excess function parameter 'parent' description in 'devm_led_classdev_unregister'
> 
> Cc: Pavel Machek <pavel@....cz>
> Cc: John Lenz <lenz@...wisc.edu>
> Cc: Richard Purdie <rpurdie@...nedhand.com>
> Cc: linux-leds@...r.kernel.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>  drivers/leds/led-class.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
> index 2e495ff678562..16271a1de12a7 100644
> --- a/drivers/leds/led-class.c
> +++ b/drivers/leds/led-class.c
> @@ -513,7 +513,7 @@ static int devm_led_classdev_match(struct device *dev, void *res, void *data)
>  
>  /**
>   * devm_led_classdev_unregister() - resource managed led_classdev_unregister()
> - * @parent: The device to unregister.
> + * @dev: The device to unregister.
>   * @led_cdev: the led_classdev structure for this device.
>   */
>  void devm_led_classdev_unregister(struct device *dev,

Fixes: ca1bb4ee4c3a ("leds: Introduce devres helper for led_classdev_register")
Reviewed-by: Alexander Dahl <ada@...rsis.com>

Greets
Alex