linux-kernel - Re: [PATCH v4 0/3] gpio: gpio-regmap: Support few custom operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 May 2021 02:53:05 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
Cc:     Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Michael Walle <michael@...le.cc>,
        Florian Fainelli <f.fainelli@...il.com>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>,
        Jonas Gorski <jonas.gorski@...il.com>,
        Álvaro Fernández Rojas <noltari@...il.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-power@...rohmeurope.com,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>
Subject: Re: [PATCH v4 0/3] gpio: gpio-regmap: Support few custom operations

On Thu, May 27, 2021 at 8:32 AM Matti Vaittinen
<matti.vaittinen@...rohmeurope.com> wrote:

> I think that the disagreement boils down to few styling issues - and
> one more pragmatic one. And only what comes to how we allow
> implementing the IC specific call-backs for these more complex HW
> specific cases. "Styling" boils down to providing getter-functions for
> well-defined gpio_regmap properties like regmap, device and fwnode
> pointers Vs. exposing these in a well-defined structure as function
> parameters.

Just do it the way the maintainer likes it I guess? Michael wrote
the driver so do it in his fashion.

> So
> at the end of the day it's fair to go on in a way Michael and You find
> easiest to maintain.

What makes things easy for me to maintain is active and happy
driver maintainers, so it is paramount that the file looks to Michael
like something he wants to keep maintaining. This removes work
from me and Bartosz.

Maintainer style quirks are common, I have some myself (like
never allowing __underscore_functions) we just adapt to their
quirks and be good diplomats.

Yours,
Linus Walleij