linux-kernel - Re: [PATCH v2 6/6] ARM: use MiB for vmalloc sizes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0acfa653-1480-b474-8ad4-d3d7ef10bea5@windriver.com>
Date:   Fri, 28 May 2021 21:20:16 +0800
From:   "Xu, Yanfei" <yanfei.xu@...driver.com>
To:     "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
Cc:     rppt@...nel.org, ardb@...nel.org, linus.walleij@...aro.org,
        akpm@...ux-foundation.org, carver4lio@....com,
        tiantao6@...ilicon.com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 6/6] ARM: use MiB for vmalloc sizes



On 5/28/21 6:11 PM, Russell King (Oracle) wrote:
> [Please note: This e-mail is from an EXTERNAL e-mail address]
> 
> Rather than using "m" (which is the unit of metres, or milli), and
> "MB" in the printk statements, use MiB to make it clear that we are
> talking about the power-of-2 megabytes, aka mebibytes.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>

Reviewed-by: Yanfei Xu <yanfei.xu@...driver.com>

Regards,
Yanfei

> ---
>   arch/arm/mm/mmu.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c
> index d52647b6261c..a96e9420ec2a 100644
> --- a/arch/arm/mm/mmu.c
> +++ b/arch/arm/mm/mmu.c
> @@ -1128,7 +1128,7 @@ static unsigned long __initdata vmalloc_size = 240 * SZ_1M;
>   /*
>    * vmalloc=size forces the vmalloc area to be exactly 'size'
>    * bytes. This can be used to increase (or decrease) the vmalloc
> - * area - the default is 240m.
> + * area - the default is 240MiB.
>    */
>   static int __init early_vmalloc(char *arg)
>   {
> @@ -1137,14 +1137,14 @@ static int __init early_vmalloc(char *arg)
> 
>          if (vmalloc_reserve < SZ_16M) {
>                  vmalloc_reserve = SZ_16M;
> -               pr_warn("vmalloc area too small, limiting to %luMB\n",
> +               pr_warn("vmalloc area is too small, limiting to %luMiB\n",
>                          vmalloc_reserve >> 20);
>          }
> 
>          vmalloc_max = VMALLOC_END - (PAGE_OFFSET + SZ_32M + VMALLOC_OFFSET);
>          if (vmalloc_reserve > vmalloc_max) {
>                  vmalloc_reserve = vmalloc_max;
> -               pr_warn("vmalloc area is too big, limiting to %luMB\n",
> +               pr_warn("vmalloc area is too big, limiting to %luMiB\n",
>                          vmalloc_reserve >> 20);
>          }
> 
> --
> 2.20.1
>