linux-kernel - Re: [PATCH] Revert "kbuild: merge scripts/mkmakefile to top Makefile"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 29 May 2021 02:15:55 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Michal Suchánek <msuchanek@...e.de>
Cc:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Revert "kbuild: merge scripts/mkmakefile to top Makefile"

On Thu, May 27, 2021 at 5:28 AM Michal Suchánek <msuchanek@...e.de> wrote:
>
> On Thu, May 27, 2021 at 03:56:41AM +0900, Masahiro Yamada wrote:
> > On Thu, May 27, 2021 at 2:39 AM Michal Suchanek <msuchanek@...e.de> wrote:
> > >
> > > This reverts commit 243b50c141d71fcf7b88e94474b3b9269f0b1f9d.
> > >
> > > When packaging the kernel it is built in different place from the one in
> > > which it will be installed. After build the makefile needs to be
> > > regenerated with the target location but with mkmakefile merged into
> > > Makefile tehre is no way to do that.
> > >
> > > Signed-off-by: Michal Suchanek <msuchanek@...e.de>
> >
> > My patch was not working as expected
> > regardless of packaging.
> >
> > Does the following fix-up work for you?
>
> For the packaging I need some way to regenerate the Makefile and fake
> the directory where the Makefile will be on the user system (ie DESTDIR)
>
> Without the mkmakefile I do not see any way to do it.
>
> If the kernel makefile is no longer location dependent there is no need
> any more, of course.
>
> Thanks
>
> Michal

Sorry, I do not understand this.

IIUC, this patch does not change any functionality.
The generated Makefile is still the same.
Why is it a problem?



-- 
Best Regards
Masahiro Yamada