linux-kernel - Re: [PATCH] mfd:Add SUNIX mfd & PCIe driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210528182617.GS543307@dell>
Date:   Fri, 28 May 2021 19:26:17 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Moriis Ku <saumah@...il.com>
Cc:     linux-kernel@...r.kernel.org, jason_lee@...ix.com,
        taian.chen@...ix.com
Subject: Re: [PATCH] mfd:Add SUNIX mfd & PCIe driver

On Fri, 28 May 2021, Moriis Ku wrote:

> From: Morris Ku <saumah@...il.com>
> 
> Add SUNIX mfd & PCIe driver
> 
> Cc: Jason Lee <jason_lee@...ix.com>
> Cc: Taian Chen <taian.chen@...ix.com>
> Signed-off-by: Morris Ku <saumah@...il.com>
> ---
>  sdc_mfd.c | 513 ++++++++++++++++++++++++++++++++++++++++++++++++++++++

To be frank, this is a bit of a mess.

Let's take one step back for a moment.

Please tell me how this compares to any existing driver currently
present in drivers/mfd.  I'm 100% sure this H/W is not different to
anything we've seen before.  Thus, my advice is to base it off of a
piece of code that has been previously accepted and take it from
there.

>  sdc_mfd.h |  61 +++++++
>  sdc_pci.c |  92 ++++++++++
>  3 files changed, 666 insertions(+)
>  create mode 100644 sdc_mfd.c
>  create mode 100644 sdc_mfd.h
>  create mode 100644 sdc_pci.c


-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog