linux-kernel - Re: [PATCH bpf-next] bpf/devmap: remove drops variable from bq_xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 28 May 2021 20:20:03 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Hangbin Liu <liuhangbin@...il.com>
Cc:     bpf@...r.kernel.org, daniel@...earbox.net, toke@...hat.com,
        john.fastabend@...il.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, brouer@...hat.com
Subject: Re: [PATCH bpf-next] bpf/devmap: remove drops variable from bq_xmit_all()

Hello:

This patch was applied to bpf/bpf-next.git (refs/heads/master):

On Thu, 27 May 2021 22:43:56 -0400 you wrote:
> As Colin pointed out, the first drops assignment after declaration will
> be overwritten by the second drops assignment before using, which makes
> it useless.
> 
> Since the drops variable will be used only once. Just remove it and
> use "cnt - sent" in trace_xdp_devmap_xmit()
> 
> [...]

Here is the summary with links:
  - [bpf-next] bpf/devmap: remove drops variable from bq_xmit_all()
    https://git.kernel.org/bpf/bpf-next/c/e8e0f0f48478

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html