linux-kernel - Re: [PATCH v1 05/28] leds: el15203000: Correct headers (of*.h -> mod

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f21ff98f-8728-eea1-f9ef-c14f64d31d0e@kaa.org.ua>
Date:   Sat, 29 May 2021 00:00:23 +0300
From:   Oleh Kravchenko <oleg@....org.ua>
To:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Pavel Machek <pavel@....cz>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Amireddy Mallikarjuna reddy 
        <mallikarjunax.reddy@...ux.intel.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Marek Behún <marek.behun@....cz>,
        Abanoub Sameh <abanoubsameh8@...il.com>,
        Dan Murphy <dmurphy@...com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 05/28] leds: el15203000: Correct headers (of*.h ->
 mod_devicetable.h)

10.05.21 12:50, Andy Shevchenko пише:
> There is no user of of*.h headers, but mod_devicetable.h.
> Update header block accordingly.
> 
> While at it, drop unneeded dependency to OF.
> 
> Signed-off-by: Andy Shevchenko <andy.shevchenko@...il.com>
> ---
>  drivers/leds/Kconfig           | 1 -
>  drivers/leds/leds-el15203000.c | 3 ++-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index dcbfcd491fd0..531c79155717 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -167,7 +167,6 @@ config LEDS_EL15203000
>  	tristate "LED Support for Crane EL15203000"
>  	depends on LEDS_CLASS
>  	depends on SPI
> -	depends on OF
>  	help
>  	  This option enables support for EL15203000 LED Board
>  	  (aka RED LED board) which is widely used in coffee vending
> diff --git a/drivers/leds/leds-el15203000.c b/drivers/leds/leds-el15203000.c
> index bcdbbbc9c187..fcb90d7cd42f 100644
> --- a/drivers/leds/leds-el15203000.c
> +++ b/drivers/leds/leds-el15203000.c
> @@ -4,8 +4,9 @@
>  
>  #include <linux/delay.h>
>  #include <linux/leds.h>
> +#include <linux/mod_devicetable.h>
>  #include <linux/module.h>
> -#include <linux/of_device.h>
> +#include <linux/property.h>
>  #include <linux/spi/spi.h>
>  
>  /*
> 

Reviewed-by: Oleh Kravchenko <oleg@....org.ua>