linux-kernel - RE: [PATCH net-next v3 2/3] net: pcs: add 2500BASEX support for Intel mGbE controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 28 May 2021 01:57:58 +0000
From:   "Sit, Michael Wei Hong" <michael.wei.hong.sit@...el.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     "Jose.Abreu@...opsys.com" <Jose.Abreu@...opsys.com>,
        "hkallweit1@...il.com" <hkallweit1@...il.com>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "peppe.cavallaro@...com" <peppe.cavallaro@...com>,
        "alexandre.torgue@...s.st.com" <alexandre.torgue@...s.st.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "mcoquelin.stm32@...il.com" <mcoquelin.stm32@...il.com>,
        "Voon, Weifeng" <weifeng.voon@...el.com>,
        "Ong, Boon Leong" <boon.leong.ong@...el.com>,
        "Tan, Tee Min" <tee.min.tan@...el.com>,
        "vee.khee.wong@...ux.intel.com" <vee.khee.wong@...ux.intel.com>,
        "Wong, Vee Khee" <vee.khee.wong@...el.com>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next v3 2/3] net: pcs: add 2500BASEX support for Intel
 mGbE controller



> -----Original Message-----
> From: Andrew Lunn <andrew@...n.ch>
> Sent: Friday, 28 May, 2021 7:27 AM
> To: Sit, Michael Wei Hong <michael.wei.hong.sit@...el.com>
> Cc: Jose.Abreu@...opsys.com; hkallweit1@...il.com;
> linux@...linux.org.uk; kuba@...nel.org;
> netdev@...r.kernel.org; peppe.cavallaro@...com;
> alexandre.torgue@...s.st.com; davem@...emloft.net;
> mcoquelin.stm32@...il.com; Voon, Weifeng
> <weifeng.voon@...el.com>; Ong, Boon Leong
> <boon.leong.ong@...el.com>; Tan, Tee Min
> <tee.min.tan@...el.com>; vee.khee.wong@...ux.intel.com;
> Wong, Vee Khee <vee.khee.wong@...el.com>; linux-stm32@st-
> md-mailman.stormreply.com; linux-arm-
> kernel@...ts.infradead.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH net-next v3 2/3] net: pcs: add 2500BASEX
> support for Intel mGbE controller
> 
> > +static int xpcs_config_2500basex(struct mdio_xpcs_args *xpcs)
> {
> > +	int ret;
> > +
> > +		ret = xpcs_read(xpcs, MDIO_MMD_VEND2,
> DW_VR_MII_DIG_CTRL1);
> > +		if (ret < 0)
> > +			return ret;
> > +		ret |= DW_VR_MII_DIG_CTRL1_2G5_EN;
> > +		ret &=
> ~DW_VR_MII_DIG_CTRL1_MAC_AUTO_SW;
> > +		ret = xpcs_write(xpcs, MDIO_MMD_VEND2,
> DW_VR_MII_DIG_CTRL1, ret);
> > +		if (ret < 0)
> > +			return ret;
> > +
> > +		ret = xpcs_read(xpcs, MDIO_MMD_VEND2,
> DW_VR_MII_MMD_CTRL);
> > +		if (ret < 0)
> > +			return ret;
> > +		ret &= ~AN_CL37_EN;
> > +		ret |= SGMII_SPEED_SS6;
> > +		ret &= ~SGMII_SPEED_SS13;
> > +		return xpcs_write(xpcs, MDIO_MMD_VEND2,
> DW_VR_MII_MMD_CTRL, ret);
> > +
> > +	return 0;
> 
> Indentation is messed up here? Or a rebase gone wrong
> removing an if statement?
> 
Thanks Andrew! Good catch, missed this indentation error,
will fix in next revision
> 	    Andrew