linux-kernel - Re: [PATCH v1 11/28] leds: lgm-sso: Remove explicit managed resource cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VcnKJj_2G5xiBXCGQmo3XqV=jR1J64zoimiBr162rw+DA@mail.gmail.com>
Date:   Sat, 29 May 2021 12:46:43 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Pavel Machek <pavel@....cz>
Cc:     Amireddy Mallikarjuna reddy <mallikarjunax.reddy@...ux.intel.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Marek Behún <marek.behun@....cz>,
        Abanoub Sameh <abanoubsameh8@...il.com>,
        Dan Murphy <dmurphy@...com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 11/28] leds: lgm-sso: Remove explicit managed resource cleanups

On Fri, May 28, 2021 at 1:50 PM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
>
> On Fri, May 28, 2021 at 12:09:06PM +0200, Pavel Machek wrote:
> > On Mon 2021-05-10 12:50:28, Andy Shevchenko wrote:
> > > The idea of managed resources that they will be cleaned up automatically
> > > and in the proper order. Remove explicit cleanups.
> >
> > Are you really sure this is good idea with the regmap_update_bits in
> > between?
>
> Good question. I will check it.
>
> > > -   /* unregister led */
> > > -   devm_led_classdev_unregister(priv->dev, &led->cdev);

I left this untouched, i.o.w. no removal in v2.

-- 
With Best Regards,
Andy Shevchenko