linux-kernel - Re: [PATCH v8 5/5] arm64: boot: dts: qcom: sm8150: Enable dynamic TX FIFO resize logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YLJ000lIVhZM5WEV@builder.lan>
Date:   Sat, 29 May 2021 12:07:31 -0500
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Wesley Cheng <wcheng@...eaurora.org>
Cc:     balbi@...nel.org, gregkh@...uxfoundation.org, agross@...nel.org,
        robh+dt@...nel.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, jackp@...eaurora.org,
        Thinh.Nguyen@...opsys.com
Subject: Re: [PATCH v8 5/5] arm64: boot: dts: qcom: sm8150: Enable dynamic TX
 FIFO resize logic

On Wed 19 May 02:43 CDT 2021, Wesley Cheng wrote:

> Enable the flexible TX FIFO resize logic on SM8150.  Using a larger TX FIFO
> SZ can help account for situations when system latency is greater than the
> USB bus transmission latency.
> 
> Reviewed-by: Rob Herring <robh@...nel.org>
> Signed-off-by: Wesley Cheng <wcheng@...eaurora.org>

Based on my previous request of always adding this for the Qualcomm
platforms that supports it, which is implemented in patch 4, I don't see
a need for this patch.

Am I missing something?

Regards,
Bjorn

> ---
>  arch/arm64/boot/dts/qcom/sm8150.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> index 51235a9..8f532cb 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> @@ -2275,6 +2275,7 @@
>  				iommus = <&apps_smmu 0x140 0>;
>  				snps,dis_u2_susphy_quirk;
>  				snps,dis_enblslpm_quirk;
> +				tx-fifo-resize;
>  				phys = <&usb_1_hsphy>, <&usb_1_ssphy>;
>  				phy-names = "usb2-phy", "usb3-phy";
>  			};
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>