linux-kernel - Re: [PATCH] clk: sifive: Fix kernel-doc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 29 May 2021 16:08:13 -0700 (PDT)
From:   Palmer Dabbelt <palmer@...belt.com>
To:     yang.lee@...ux.alibaba.com
CC:     mturquette@...libre.com, sboyd@...nel.org,
        Paul Walmsley <paul.walmsley@...ive.com>,
        linux-clk@...r.kernel.org, linux-riscv@...ts.infradead.org,
        linux-kernel@...r.kernel.org, yang.lee@...ux.alibaba.com
Subject:     Re: [PATCH] clk: sifive: Fix kernel-doc

On Mon, 24 May 2021 03:22:10 PDT (-0700), yang.lee@...ux.alibaba.com wrote:
> Fix function name in sifive-prci.c kernel-doc comment
> to remove a warning.
>
> drivers/clk/sifive/sifive-prci.c:573: warning: expecting prototype for
> sifive_prci_init(). Prototype was for sifive_prci_probe() instead
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>  drivers/clk/sifive/sifive-prci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/sifive/sifive-prci.c b/drivers/clk/sifive/sifive-prci.c
> index 0d79ba3..80a288c 100644
> --- a/drivers/clk/sifive/sifive-prci.c
> +++ b/drivers/clk/sifive/sifive-prci.c
> @@ -564,7 +564,7 @@ static int __prci_register_clocks(struct device *dev, struct __prci_data *pd,
>  }
>
>  /**
> - * sifive_prci_init() - initialize prci data and check parent count
> + * sifive_prci_probe() - initialize prci data and check parent count
>   * @pdev: platform device pointer for the prci
>   *
>   * Return: 0 upon success or a negative error code upon failure.

Acked-by: Palmer Dabbelt <palmerdabbelt@...gle.com>
Reviewed-by: Palmer Dabbelt <palmerdabbelt@...gle.com>

I'm assuming this is targeted for the clock tree, but LMK if you want me 
to take it.

Thanks!