linux-kernel - Re: [PATCH -next] PM / devfreq: governor: use DEVICE_ATTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d607250d-e01f-367a-8739-a093fe0e88e7@gmail.com>
Date:   Sat, 29 May 2021 12:15:23 +0900
From:   Chanwoo Choi <cwchoi00@...il.com>
To:     YueHaibing <yuehaibing@...wei.com>, myungjoo.ham@...sung.com,
        kyungmin.park@...sung.com, cw00.choi@...sung.com
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] PM / devfreq: governor: use DEVICE_ATTR_RW macro

On 21. 5. 24. 오전 11:11, YueHaibing wrote:
> Use DEVICE_ATTR_RW helper instead of plain DEVICE_ATTR,
> which makes the code a bit shorter and easier to read.
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>   drivers/devfreq/governor_userspace.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/devfreq/governor_userspace.c b/drivers/devfreq/governor_userspace.c
> index 0fd6c4851071..ab9db7adb3ad 100644
> --- a/drivers/devfreq/governor_userspace.c
> +++ b/drivers/devfreq/governor_userspace.c
> @@ -31,8 +31,8 @@ static int devfreq_userspace_func(struct devfreq *df, unsigned long *freq)
>   	return 0;
>   }
>   
> -static ssize_t store_freq(struct device *dev, struct device_attribute *attr,
> -			  const char *buf, size_t count)
> +static ssize_t set_freq_store(struct device *dev, struct device_attribute *attr,
> +			      const char *buf, size_t count)
>   {
>   	struct devfreq *devfreq = to_devfreq(dev);
>   	struct userspace_data *data;
> @@ -52,8 +52,8 @@ static ssize_t store_freq(struct device *dev, struct device_attribute *attr,
>   	return err;
>   }
>   
> -static ssize_t show_freq(struct device *dev, struct device_attribute *attr,
> -			 char *buf)
> +static ssize_t set_freq_show(struct device *dev,
> +			     struct device_attribute *attr, char *buf)
>   {
>   	struct devfreq *devfreq = to_devfreq(dev);
>   	struct userspace_data *data;
> @@ -70,7 +70,7 @@ static ssize_t show_freq(struct device *dev, struct device_attribute *attr,
>   	return err;
>   }
>   
> -static DEVICE_ATTR(set_freq, 0644, show_freq, store_freq);
> +static DEVICE_ATTR_RW(set_freq);
>   static struct attribute *dev_entries[] = {
>   	&dev_attr_set_freq.attr,
>   	NULL,
> 

Applied it. Thanks.

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi