linux-kernel - Re: [PATCH 1/1] of: unittest: rename overlay source files from .dts to .dtso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YLBnX4PeK51YwUJB@yekko>
Date:   Fri, 28 May 2021 13:45:35 +1000
From:   David Gibson <david@...son.dropbear.id.au>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Frank Rowand <frowand.list@...il.com>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Rob Herring <robh@...nel.org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Michal Simek <michal.simek@...inx.com>,
        Anmar Oueja <anmar.oueja@...aro.org>,
        Bill Mills <bill.mills@...aro.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-kbuild <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] of: unittest: rename overlay source files from .dts
 to .dtso

On Thu, May 27, 2021 at 09:21:05AM +0200, Geert Uytterhoeven wrote:
65;6401;1c> On Thu, May 27, 2021 at 3:48 AM David Gibson
> <david@...son.dropbear.id.au> wrote:
> > On Wed, May 26, 2021 at 04:21:48PM -0500, Frank Rowand wrote:
> > > On 5/26/21 1:11 AM, Viresh Kumar wrote:
> > > > On 22-04-21, 13:54, Frank Rowand wrote:
> > > >> On 4/22/21 3:44 AM, Geert Uytterhoeven wrote:
> > > >>> On Mon, Mar 29, 2021 at 9:23 PM Frank Rowand <frowand.list@...il.com> wrote:
> > > >>>> On 3/27/21 12:40 PM, Rob Herring wrote:
> > > >>>>> On Wed, Mar 24, 2021 at 05:37:13PM -0500, frowand.list@...il.com wrote:
> > > >>>>>> From: Frank Rowand <frank.rowand@...y.com>
> > > >>>>>>
> > > >>>>>> Add Makefile rule to build .dtbo.o assembly file from overlay .dtso
> > > >>>>>> source file.
> > > >>>>>>
> > > >>>>>> Rename unittest .dts overlay source files to use .dtso suffix.
> > > >>>>>
> > > >>>>> I'm pretty lukewarm on .dtso...
> > > >>>>
> > > >>>> I was originally also, but I'm warming up to it.
> > > >>>
> > > >>> What's the status of this?
> > > >>
> > > >> I was planning to resend on top of the upcoming -rc1.
> > > >
> > > > Ping.
> > > >
> > >
> > > Thanks for the prod...
> > >
> > > The .dtso convention was added to the dtc compiler, then a patch was
> > > accepted to revert one mention of .dtso ,though there still remains
> > > two location where .dtbo is still recognized (guess_type_by_name() in
> > > dtc and the help text of the fdtoverlay program).
> > >
> > > It seems that the general .dtso and .dtbo were not popular, so I'm
> > > going to drop this patch instead of continuing to try to get it
> > > accepted.
> >
> > AFAICT .dtbo is moderately well established, and I think it's a good
> > convention, since it matters whether a blob is an overlay or base
> > tree, and it's not trivial to tell which is which.
> 
> Indeed.
> 
> > .dtso is much more recent,
> 
> Is it?

Well, I wouldn't bet money on it, I just seem to remember encountering
.dtbo for some time before .dtso was mentioned.

> The oldest reference I could find is from May 2015:
> "[PATCH/RFC] kbuild: Create a rule for building device tree overlay objects"
> https://lore.kernel.org/linux-devicetree/1431431816-24612-1-git-send-email-geert+renesas@glider.be/

Hm, I think .dtbo is even older than that, but again, I wouldn't swear
to it.

> I have always used dtbo/dtso in my published overlays branches,
> referred from https://elinux.org/R-Car/DT-Overlays, and used by
> various people.
> 
> > and I think there's much less value to it.
> 
> IMHO the same reasoning as for dtb vs. dtbo applies to dts vs. dtso.
> It matters if the resulting blob will be an overlay or base tree,
> as the blob will have to be called .dtb or .dtbo.
> As dtc outputs to stdout by default, the caller has to provide the
> output filename, and thus needs to know.
> Even if dtc would name the output file based on the presence of
> "/plugin/" in the input file, the build system still needs to know
> for dependency tracking.

Hm, fair point.  I was thinking of the the /plugin/ tag as the
distinction, whereas dtb is binary and the distinction isn't even
marked in the header.  But you're right that even readable text labels
inside the file don't really help make(1).  So, I retract that
assertion.

> We also do have .dts vs. .dtsi.
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)