linux-kernel - [PATCH -next 1/3] cifsd: fix memleak in ksmbd_vfs_stream

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210529082058.3012233-1-yangyingliang@huawei.com>
Date:   Sat, 29 May 2021 16:20:56 +0800
From:   Yang Yingliang <yangyingliang@...wei.com>
To:     <linux-kernel@...r.kernel.org>,
        <linux-cifsd-devel@...ts.sourceforge.net>,
        <linux-cifs@...r.kernel.org>
CC:     <namjae.jeon@...sung.com>, <sergey.senozhatsky@...il.com>,
        <sfrench@...ba.org>, <hyc.lee@...il.com>
Subject: [PATCH -next 1/3] cifsd: fix memleak in ksmbd_vfs_stream_write()

Before assigning wbuf to stream_buf, memory allocate in
ksmbd_vfs_getcasexattr() need be freed.

Fixes: f44158485826 ("cifsd: add file operations")
Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
---
 fs/cifsd/vfs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/cifsd/vfs.c b/fs/cifsd/vfs.c
index 291953eff5fa..9057b30278b9 100644
--- a/fs/cifsd/vfs.c
+++ b/fs/cifsd/vfs.c
@@ -429,6 +429,7 @@ static int ksmbd_vfs_stream_write(struct ksmbd_file *fp, char *buf, loff_t *pos,
 
 		if (v_len > 0)
 			memcpy(wbuf, stream_buf, v_len);
+		kfree(stream_buf);
 		stream_buf = wbuf;
 	}
 
-- 
2.25.1