linux-kernel - Re: [PATCH] agp: remove set but not used variable 'current

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e44124e2-fc8b-e726-8bb2-d39095155d0d@huawei.com>
Date:   Sat, 29 May 2021 17:05:38 +0800
From:   "yukuai (C)" <yukuai3@...wei.com>
To:     <airlied@...ux.ie>
CC:     <linux-kernel@...r.kernel.org>, <yi.zhang@...wei.com>
Subject: Re: [PATCH] agp: remove set but not used variable 'current_size'

ping...

On 2021/05/14 14:22, Yu Kuai wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/char/agp/via-agp.c:131:28: warning: variable ‘current_size’
> set but not used [-Wunused-but-set-variable]
> 
> It is never used, and so can be removed.
> 
> Signed-off-by: Yu Kuai <yukuai3@...wei.com>
> ---
>   drivers/char/agp/via-agp.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/char/agp/via-agp.c b/drivers/char/agp/via-agp.c
> index 87a92a044570..dc594f4eca38 100644
> --- a/drivers/char/agp/via-agp.c
> +++ b/drivers/char/agp/via-agp.c
> @@ -128,9 +128,6 @@ static int via_fetch_size_agp3(void)
>   static int via_configure_agp3(void)
>   {
>   	u32 temp;
> -	struct aper_size_info_16 *current_size;
> -
> -	current_size = A_SIZE_16(agp_bridge->current_size);
>   
>   	/* address to map to */
>   	agp_bridge->gart_bus_addr = pci_bus_address(agp_bridge->dev,
>