linux-kernel - Re: [PATCH] perf stat: Fix error return code in bperf_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2b377d87-1356-7422-326d-4d1b4132e75c@huawei.com>
Date:   Sat, 29 May 2021 17:10:35 +0800
From:   "yukuai (C)" <yukuai3@...wei.com>
To:     <peterz@...radead.org>, <mingo@...hat.com>, <acme@...nel.org>,
        <ast@...nel.org>, <daniel@...earbox.net>, <andrii@...nel.org>
CC:     <linux-perf-users@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <netdev@...r.kernel.org>, <bpf@...r.kernel.org>,
        <yi.zhang@...wei.com>
Subject: Re: [PATCH] perf stat: Fix error return code in bperf__load()

ping ...

On 2021/05/17 16:12, Yu Kuai wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Yu Kuai <yukuai3@...wei.com>
> ---
>   tools/perf/util/bpf_counter.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/tools/perf/util/bpf_counter.c b/tools/perf/util/bpf_counter.c
> index ddb52f748c8e..843b20aa6688 100644
> --- a/tools/perf/util/bpf_counter.c
> +++ b/tools/perf/util/bpf_counter.c
> @@ -522,6 +522,7 @@ static int bperf__load(struct evsel *evsel, struct target *target)
>   	evsel->bperf_leader_link_fd = bpf_link_get_fd_by_id(entry.link_id);
>   	if (evsel->bperf_leader_link_fd < 0 &&
>   	    bperf_reload_leader_program(evsel, attr_map_fd, &entry))
> +		err = -1;
>   		goto out;
>   
>   	/*
> @@ -550,6 +551,7 @@ static int bperf__load(struct evsel *evsel, struct target *target)
>   	/* Step 2: load the follower skeleton */
>   	evsel->follower_skel = bperf_follower_bpf__open();
>   	if (!evsel->follower_skel) {
> +		err = -1;
>   		pr_err("Failed to open follower skeleton\n");
>   		goto out;
>   	}
>