linux-kernel - sunxi: Bluetooth broken since 5.6-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 30 May 2021 17:34:54 +0100
From:   Andre Przywara <andre.przywara@....com>
To:     Ondrej Jirman <megous@...ous.com>, Chen-Yu Tsai <wens@...e.org>,
        Maxime Ripard <mripard@...nel.org>,
        Jernej Škrabec <jernej.skrabec@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        linux-serial@...r.kernel.org,
        Linux ARM Mailing List <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Marcel Holtmann <marcel@...tmann.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        linux-bluetooth@...r.kernel.org, linux-sunxi@...ts.linux.dev
Cc:     Josh Triplett <josh@...htriplett.org>, tuxd3v@...o.pt
Subject: sunxi: Bluetooth broken since 5.6-rc1

Hi,

as recently discovered via IRC discussions, Bluetooth (via UART)
seems to be broken on many (if not all) Allwinner devices using recent
mainline kernels. On *some* occasions it might work, but more often
than not the hci_bcm driver just times out:
....
[    5.046126] Bluetooth: HIDP socket layer initialized
...
[    7.809425] Bluetooth: hci0: command 0x0c03 tx timeout
[   15.969286] Bluetooth: hci0: BCM: Reset failed (-110)

After some guessing, trying, and bisecting I pinned the problem down to:
commit dc56ecb81a0aa46a7e127e916df5c8fdb8364f0b
Author: Josh Triplett <josh@...htriplett.org>
Date:   Fri Jan 10 18:25:13 2020 -0800

    serial: 8250: Support disabling mdelay-filled probes of 16550A variants

This seemingly innocent commit shaved off some milliseconds during the
8250 probe, which apparently lets the Bluetooth device trip.

An obvious easy hack-fix is to just define
CONFIG_SERIAL_8250_16550A_VARIANTS, which brings the delays back and
seems to avoid the problem for me.
Another hack which seems to mitigate the problem is to avoid switching
the baudrate to something faster than 115200.

I observed this on a BananaPi-M64 (Allwinner A64 SoC with AP6212 WiFi/BT
chip), but others reported the same issue on a NanoPi Air (Allwinner H3
with 6212), but also other SoCs and devices (at least one AP6210).

Obviously those workarounds are not real solutions, and I was
wondering if anybody has an idea how to properly fix this?
What puzzles me is that the delay is happening during the *UART*
probe, so before we even start dealing with the Bluetooth device.

I see that hci_bcm.c has some history with adding delays, also with
RTS/CTS lines, so does anyone have an idea what's going on here,
exactly, and how to properly fix this problem?

Many thanks,
Andre