linux-kernel - Re: [PATCH v2] fb_defio: Remove custom address_space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2977064f-42d0-7b64-176d-9509c205bfc3@kernel.org>
Date:   Sun, 30 May 2021 15:40:44 -0700
From:   Nathan Chancellor <nathan@...nel.org>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
        William Kucharski <william.kucharski@...cle.com>,
        Jani Nikula <jani.nikula@...el.com>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        Ian Campbell <ijc@...lion.org.uk>,
        linux-fsdevel@...r.kernel.org,
        Jaya Kumar <jayakumar.lkml@...il.com>,
        Christoph Hellwig <hch@....de>
Subject: Re: [PATCH v2] fb_defio: Remove custom address_space_operations

On 5/30/2021 2:14 PM, Matthew Wilcox wrote:
> On Sun, May 30, 2021 at 12:13:05PM -0700, Nathan Chancellor wrote:
>> Hi Matthew,
>>
>> On Wed, Mar 10, 2021 at 06:55:30PM +0000, Matthew Wilcox (Oracle) wrote:
>>> There's no need to give the page an address_space.  Leaving the
>>> page->mapping as NULL will cause the VM to handle set_page_dirty()
>>> the same way that it's handled now, and that was the only reason to
>>> set the address_space in the first place.
>>>
>>> Signed-off-by: Matthew Wilcox (Oracle) <willy@...radead.org>
>>> Reviewed-by: Christoph Hellwig <hch@....de>
>>> Reviewed-by: William Kucharski <william.kucharski@...cle.com>
>>
>> This patch in mainline as commit ccf953d8f3d6 ("fb_defio: Remove custom
>> address_space_operations") causes my Hyper-V based VM to no longer make
>> it to a graphical environment.
> 
> Hi Nathan,
> 
> Thanks for the report.  I sent Daniel a revert patch with a full
> explanation last week, which I assume he'll queue up for a pull soon.
> You can just git revert ccf953d8f3d6 for yourself until that shows up.
> Sorry for the inconvenience.
> 

Thank you for the quick response! I will keep an eye out for the patch 
while reverting it locally in the meantime.

Cheers,
Nathan