linux-kernel - Re: [PATCH] S390: appldata depends on PROC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <your-ad-here.call-01622470160-ext-4376@work.hours>
Date:   Mon, 31 May 2021 16:09:20 +0200
From:   Vasily Gorbik <gor@...ux.ibm.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org, Heiko Carstens <hca@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        linux-s390@...r.kernel.org
Subject: Re: [PATCH] S390: appldata depends on PROC_SYSCTL

On Thu, May 27, 2021 at 05:24:20PM -0700, Randy Dunlap wrote:
> APPLDATA_BASE should depend on PROC_SYSCTL instead of PROC_FS.
> Building with PROC_FS but not PROC_SYSCTL causes a build error,
> since appldata_base.c uses data and APIs from fs/proc/proc_sysctl.c.
> 
> arch/s390/appldata/appldata_base.o: in function `appldata_generic_handler':
> appldata_base.c:(.text+0x192): undefined reference to `sysctl_vals'
> 
> Fixes: c185b783b099 ("[S390] Remove config options.")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Heiko Carstens <hca@...ux.ibm.com>
> Cc: Vasily Gorbik <gor@...ux.ibm.com>
> Cc: Christian Borntraeger <borntraeger@...ibm.com>
> Cc: linux-s390@...r.kernel.org
> ---
>  arch/s390/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-next-20210526.orig/arch/s390/Kconfig
> +++ linux-next-20210526/arch/s390/Kconfig
> @@ -853,7 +853,7 @@ config CMM_IUCV
>  config APPLDATA_BASE
>  	def_bool n
>  	prompt "Linux - VM Monitor Stream, base infrastructure"
> -	depends on PROC_FS
> +	depends on PROC_SYSCTL
>  	help
>  	  This provides a kernel interface for creating and updating z/VM APPLDATA
>  	  monitor records. The monitor records are updated at certain time

Applied, thanks