linux-kernel - [PATCH 5.12 053/296] md/raid5: remove an incorrect assert in in_chunk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210531130705.606176292@linuxfoundation.org>
Date:   Mon, 31 May 2021 15:11:48 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     linux-kernel@...r.kernel.org
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        stable@...r.kernel.org, Florian Dazinger <spam02@...inger.net>,
        Guoqing Jiang <jiangguoqing@...inos.cn>,
        Christoph Hellwig <hch@....de>, Song Liu <song@...nel.org>
Subject: [PATCH 5.12 053/296] md/raid5: remove an incorrect assert in in_chunk_boundary

From: Christoph Hellwig <hch@....de>

commit cc146267914950b12c2bdee68c1e9e5453c81cde upstream.

Now that the original bdev is stored in the bio this assert is incorrect
and will trigger for any partitioned raid5 device.

Reported-by: Florian Dazinger <spam02@...inger.net>
Tested-by: Florian Dazinger <spam02@...inger.net>
Cc: stable@...r.kernel.org # 5.12
Fixes: 309dca309fc3 ("block: store a block_device pointer in struct bio"),
Reviewed-by:  Guoqing Jiang <jiangguoqing@...inos.cn>
Signed-off-by: Christoph Hellwig <hch@....de>
Signed-off-by: Song Liu <song@...nel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
---
 drivers/md/raid5.c |    2 --
 1 file changed, 2 deletions(-)

--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -5310,8 +5310,6 @@ static int in_chunk_boundary(struct mdde
 	unsigned int chunk_sectors;
 	unsigned int bio_sectors = bio_sectors(bio);
 
-	WARN_ON_ONCE(bio->bi_bdev->bd_partno);
-
 	chunk_sectors = min(conf->chunk_sectors, conf->prev_chunk_sectors);
 	return  chunk_sectors >=
 		((sector & (chunk_sectors - 1)) + bio_sectors);